Conversation
There was a problem hiding this comment.
Pull Request Overview
Refactors subprocess calls to support timeouts, centralizes ELF parsing constants, enhances logging, and fixes a typo in distribution parsing.
- Introduce
check_output_with_timeoutwith signal-based timeout and replace allcheck_outputcalls - Add constants (
ELF_MAGIC_BYTES,PROC_TIMEOUT,MAX_NOTE_SIZE,BYTE_ALIGNMENT), note-size validation, and logging improvements - Correct
description_version_idkey typo and update tests (including Unicode normalization)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| uchecker.py | Added timeout wrapper, constants, ELF validation, improved logging and error handling |
| tests/test_kernelcare.py | Updated mocks to use check_output_with_timeout and added Unicode normalize test |
Comments suppressed due to low confidence (2)
tests/test_kernelcare.py:22
- Add dedicated unit tests for
check_output_with_timeoutto cover normal execution, subprocess errors, and timeout-triggered paths to ensure cleanup of alarms and handlers.
def tests_get_patched_data(mock_system, tmpdir):
uchecker.py:78
- [nitpick] Expand this docstring to clarify behavior on platforms without
SIGALRM(no timeout enforcement) and describe return values on errors or timeouts.
"""Enhanced check_output with timeout support for Python 2/3."""
uchecker.py
Outdated
| signal.signal(signal.SIGALRM, old_handler) | ||
| raise | ||
|
|
||
| except (subprocess.SubprocessError, OSError) as e: |
There was a problem hiding this comment.
Referencing subprocess.SubprocessError may break on Python versions where SubprocessError isn’t defined (e.g., Python 2). Consider using getattr(subprocess, 'SubprocessError', OSError) or catching OSError and subprocess.CalledProcessError instead.
Suggested change
| except (subprocess.SubprocessError, OSError) as e: | |
| except (getattr(subprocess, 'SubprocessError', OSError), OSError) as e: |
There was a problem hiding this comment.
Pull Request Overview
Adds timeout support to subprocess calls, replaces magic values with named constants for ELF parsing, and fixes a typo in distribution parsing.
- Introduces
check_output_with_timeoutwith a default timeout and enhanced exception handling - Defines
ELF_MAGIC_BYTES,PROC_TIMEOUT,MAX_NOTE_SIZE, andBYTE_ALIGNMENT, replacing inline values inget_build_id - Corrects the
description_version_idtypo in_linux_distributionand updates tests for the new function and Unicode normalization
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| uchecker.py | Added constants, implemented check_output_with_timeout, replaced magic values, improved logging formatting, fixed typo in distribution parsing |
| tests/test_kernelcare.py | Updated tests to patch check_output_with_timeout and added test_normalize_unicode |
Comments suppressed due to low confidence (2)
tests/test_kernelcare.py:117
- There are no tests covering
check_output_with_timeout, including timeout and error paths. Add unit tests for normal execution, timeouts, non-zero exit codes, and subprocess errors.
def test_normalize_unicode():
uchecker.py:49
- [nitpick] Consider renaming
PROC_TIMEOUTtoDEFAULT_PROC_TIMEOUT_SECSor similar for clearer intent that this value is in seconds.
PROC_TIMEOUT = 30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.